Add ignores_find_in_page to inert global attribute
#25984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duplicated from `api.HTMLElement.inert.ignores_find_in_page`.
github-actions
bot
added
data:html
Elchi3
reviewed
Feb 27, 2025
| "ignores_find_in_page": { | ||
| "__compat": { | ||
| "description": "Element is ignored for the purposes of find-in-page.", | ||
| "mdn_url": "https://developer.mozilla.org/docs/Web/API/HTMLElement/inert", |
There was a problem hiding this comment.
I don't see any useful docs on find-in-page the HTMLElement page.
Suggested change
| "mdn_url": "https://developer.mozilla.org/docs/Web/API/HTMLElement/inert", | |
| "mdn_url": "https://developer.mozilla.org/docs/Web/HTML/Global_attributes/inert", |
There was a problem hiding this comment.
At second glance, shouldn't we remove the mdn_url here and from api.HTMLElement.inert.ignores_find_in_page, given that it refers to the parent feature, which has this mdn_url? Consumers can duplicate the mdn_url down if they want to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds subfeature
ignores_find_in_pagetohtml.global_attributes.inert, duplicated fromapi.HTMLElement.inert.Test results and supporting details
Related issues
Fixes #25983.